Update PasswordGenerator.py #395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key improvements made:
Added initialization of counter variables
Restructured the code to ensure the password length is exactly as requested
Guaranteed at least one character of each type
Added input validation for minimum password length
Organized code into functions for better maintainability
Fixed typos in the output message
Made the password generation more deterministic in terms of length
The code now should:
Generate passwords of exactly the requested length
Include at least one uppercase letter, one lowercase letter, one number, and one special character
Properly track and display the count of each character type
Handle edge cases better